Fix for Chieftain resist nodes applying effects twice due to Foulborn Choir of the Storm#9643
Open
EminGul wants to merge 1 commit intoPathOfBuildingCommunity:devfrom
Open
Fix for Chieftain resist nodes applying effects twice due to Foulborn Choir of the Storm#9643EminGul wants to merge 1 commit intoPathOfBuildingCommunity:devfrom
EminGul wants to merge 1 commit intoPathOfBuildingCommunity:devfrom
Conversation
…nodes applying effects twice due to Foulborn Choir of the Storm
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #9481 .
Description of the problem being solved:
Foulborn Choir of the Storm's increased mana by overcapped lightning resist mod causes resistance conversion mods, such as Taslio, Cleansing Water, to apply twice in calculations.
This is due to how Foulborn Choir of the Storm is handled in the calculations. Since it calls the resistance, mana and reservation calculations again, it adds resistance conversion mods twice as well.
Fix just adds a flag so resistance conversion mods aren't processed twice on accident.
Steps taken to verify a working solution:
Link to a build that showcases this PR:
https://pobb.in/5cSHvaw15MUI (Screenshots based off this PoB)
https://pobb.in/V41O4IvnojAr (extra case, ES aligns with user report but I'm uncertain mana is accurate as they're saying the in-game UI is bugged. The increased mana aligns with what they're reporting.)
Before screenshot:
After screenshot: